Early return from MenuPopup::scroll_{up,down} when the menu is empty

gyscos · Aug 27, 2024 · fe88657 · fe88657
1 parent 0221d08
commit fe88657
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/cursive-core/src/views/menu_popup.rs b/cursive-core/src/views/menu_popup.rs
@@ -131,6 +131,10 @@ impl MenuPopup {
     //
     // If `self.menu.children.is_empty()`.
     fn scroll_up(&mut self, mut n: usize, mut cycle: bool) {
+        if self.menu.is_empty() {
+            return;
+        }
+
         while n > 0 {
             if self.focus > 0 {
                 self.focus -= 1;
@@ -154,6 +158,10 @@ impl MenuPopup {
     //
     // If `self.menu.children.is_empty()`.
     fn scroll_down(&mut self, mut n: usize, mut cycle: bool) {
+        if self.menu.is_empty() {
+            return;
+        }
+
         while n > 0 {
             if self.focus + 1 < self.menu.children.len() {
                 self.focus += 1;