Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTN-1557: Update Feedback component to receive Caption as a new child component #850

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

matheushdsbr
Copy link
Collaborator

@matheushdsbr matheushdsbr commented Nov 19, 2024

JIRA Issue

Description 📄

In this PR, Feedback.Caption has been added as a new child of the Feedback component.

To give context, we need to add information on the Cancellation Success screen for primary users. To do this, we need to update the feedback component with an option to add one more description (Caption).
This will give the user more information about their cancellation.

To more details: task history and figma

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Web

V3Theme V2Theme
Screenshot 2024-11-19 at 10 09 46 Screenshot 2024-11-19 at 08 57 49

Mobile/Responsive

V3Theme V2Theme
Screenshot 2024-11-19 at 10 15 56 Screenshot 2024-11-19 at 10 17 28

@flavia-moraes flavia-moraes merged commit 63615d0 into master Nov 19, 2024
3 of 4 checks passed
@flavia-moraes flavia-moraes deleted the RTN-1557 branch November 19, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants