Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞fix(build): adjust components themes #714

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

matheushdsbr
Copy link
Contributor

JIRA Issue

Description 📄

This PR resolves an issue identified in the build process concerning the import of themes following the pattern '../../**/*.theme.js' when using TSUP. The build was not correctly interpreting this import structure through regex.

The implemented solution consists of a temporary approach where imports are added manually. Our Yoga team plans to work on an automated script to eliminate the need for manually adding imports for each new component theme, enhancing code scalability and maintenance.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@matheushdsbr matheushdsbr self-assigned this Dec 6, 2023
@matheushdsbr matheushdsbr merged commit cbd1994 into master Dec 7, 2023
3 checks passed
@matheushdsbr matheushdsbr deleted the fix/build-theme branch December 7, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants