Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yoga): add props to PlanCard.ListItem #694

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

leonardo-gympass
Copy link
Contributor

JIRA Issue

Description 📄

<PlanCard.ListItem />

  • Add truncate prop to be able to remove the truncate behavior.
  • Add children props to add an additional content inside the list item.
<PlanCard.ListItem
  {...props}
  truncate={false}
>
  <Avatar />
</PlanCard.ListItem>

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

add children and truncate props
@matheushdsbr matheushdsbr merged commit 75c8319 into master Sep 28, 2023
@matheushdsbr matheushdsbr deleted the feat/add-props-to-plan-card-list-item branch September 28, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants