refactor(button): set defaultProps disabled as undefined

gympass · Oct 2, 2023 · cbbda49 · cbbda49
1 parent 00e1edc
commit cbbda49
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/yoga/src/Button/web/Button.jsx b/packages/yoga/src/Button/web/Button.jsx
@@ -31,7 +31,7 @@ const Button = forwardRef(
       <StyledButton
         ref={ref}
         disabled={disabled}
-        aria-disabled={disabled || undefined}
+        aria-disabled={disabled}
         aria-label={ariaLabel}
         full={full}
         inverted={inverted}
@@ -64,7 +64,7 @@ Button.propTypes = {
 Button.defaultProps = {
   ariaLabel: undefined,
   children: 'Button',
-  disabled: false,
+  disabled: undefined,
   full: false,
   inverted: false,
   onClick: () => {},

diff --git a/packages/yoga/src/Button/web/Icon.jsx b/packages/yoga/src/Button/web/Icon.jsx
@@ -50,7 +50,7 @@ const ButtonIcon = forwardRef(
         ref={ref}
         small={small}
         disabled={disabled}
-        aria-disabled={disabled || undefined}
+        aria-disabled={disabled}
         aria-label={ariaLabel}
       >
         <Icon
@@ -73,7 +73,7 @@ ButtonIcon.propTypes = {
 
 ButtonIcon.defaultProps = {
   small: false,
-  disabled: false,
+  disabled: undefined,
   secondary: false,
   inverted: false,
   icon: undefined,

diff --git a/packages/yoga/src/Button/web/Link.jsx b/packages/yoga/src/Button/web/Link.jsx
@@ -69,7 +69,7 @@ const Link = styled(Button)`
 `;
 
 const ButtonLink = ({ disabled, ...props }) => (
-  <Link {...props} disabled={disabled} aria-disabled={disabled || undefined} />
+  <Link {...props} disabled={disabled} aria-disabled={disabled} />
 );
 
 ButtonLink.propTypes = {
@@ -81,7 +81,7 @@ ButtonLink.propTypes = {
 };
 
 ButtonLink.defaultProps = {
-  disabled: false,
+  disabled: undefined,
   secondary: false,
   href: undefined,
   icon: undefined,