Update and improve help info logs #10081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegegoku
force-pushed
the
helpinfo-update-test
branch
from
0d70267 to
c6beedc
Compare
niloc132
reviewed
Feb 5, 2025
| GWTProblem.recordError(node, cud, error, new InstalledHelpInfo( | ||
| "jsoRestrictions.html")); | ||
| GWTProblem.recordError(node, cud, error, new GwtprojectOrgHelpInfo( | ||
| "/doc/latest/DevGuideCodingBasicsJSNI.html")); |
There was a problem hiding this comment.
why not link to the jsoRestrictions.html file that was moved?
| * Any violations found are attached as errors on the | ||
| * CompilationUnitDeclaration. | ||
| * | ||
| * @see <a | ||
| * href="http://code.google.com/p/google-web-toolkit/wiki/OverlayTypes">Overlay | ||
| * types design doc</a> | ||
| * @see jsoRestrictions.html | ||
| * @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html">jsoRestrictions.html</a> |
There was a problem hiding this comment.
Could point to the same file after moving it.
|
|
||
| public GwtprojectOrgHelpInfo(String relativeUrl) { | ||
| try { | ||
| url = new URL("https://gwtproject.org" + relativeUrl); |
There was a problem hiding this comment.
All constructor calls seem to start with /doc/latest/gwt-dev-help/, can we include that in the path here?
If we ever want an absolute link to somewhere else, we could have a factory method for "help(pagename)" vs "article(path)"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update, migrate, improve log help links
Fix #10042
See also gwtproject/gwt-site#386