-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build the site when something is pushed to main, or on PRs #9
base: main
Are you sure you want to change the base?
Conversation
This commit changes nothing in the output except for how it is produced, and ideally paves the way to more simply producing just the output we need for the website.
There is room for improvement here, this is meant to be a first draft before we start merging other cleanup.
(wrong issue commented on) |
Build summary, with downloadable generated JS https://github.com/niloc132/gwt-site-webapp/actions/runs/4338262581 (requires #11) |
|
||
<properties> | ||
<maven.build.timestamp.format>yyyy-MM-dd</maven.build.timestamp.format> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
|
||
<gwt.version>2.7.0</gwt.version> | ||
<gwtquery.version>1.4.2</gwtquery.version> | ||
<gwt.version>2.9.0</gwt.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to using the BOM?
@@ -17,36 +16,24 @@ | |||
- To **build** and check the app, run | |||
|
|||
$ cd [...]/gwt-site-webapp | |||
$ mvn package | |||
$ mvn verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the full-site
profile be mentioned somewhere in the README?
There is room for improvement here, this is meant to be a first draft
before we start merging other cleanup, to validate those merges.
Fixes #7