Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra - when setting title for homepage #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

niloc132
Copy link
Contributor

No description provided.


$("#nav a.active").removeClass("active");
$("#nav a[href='" + mainNavigationHref + "']").addClass("active");
$("#submenu .active").not(liParents).removeClass("active");
liParents.add(selectedItem).not(selectedItem.parent()).addClass("active");

// Change the page title for easy bookmarking
$("title").text("[GWT] " + subMenuItem.children("a").text() + " - " + selectedItem.text());
if (section.isEmpty()) {
$("title").text("GWT Project Homepage");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably remove the word "Homepage".

Currently there are

  1. gwtproject.org
  2. gwtproject.org/overview.html

which do not have a submenu. So both would show "GWT Project Homepage" even though only 1. should.

In order to fix the overview.html page and being able to set a title for it, the code would also need to check GQuery selectedItem = $("#nav a[href='" + path + "']") because the current path isn't found in a #submenu (see line 128).

niloc132 pushed a commit that referenced this pull request Oct 27, 2024
As discussed in Gitter, GWTQuery breaks navigation when certain Chrome
extensions are active. This should also reduce the code size a bit.

Closes #11 -- all the changes are included here to make Elemental work.

Most functionality stays the same, page title for hompage changed,
which makes this conflicted with #1.

Fixes #5
Fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The title of gwtproject.org is [GWT] - , since there is no heading or subheading to show
2 participants