Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to switch to jakarta namespace #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ManfredTremmel
Copy link

switched from javax.inject to jakarta.inject namespace

  • guice updated from 4.2.3 to 7.0.0
  • gwt updated from 2.9.0 to 2.12.1
  • all other dependencies updated to latest versions
  • java minimum requirement now is 11

- guice updated from 4.2.3 to 7.0.0
- gwt updated from 2.9.0 to 2.12.1
- all other dependencies updated to latest versions
- java minimum requirement now is 11
@metteo
Copy link
Member

metteo commented Dec 5, 2024

Hi, thank you for the PR. I'll setup GitHub actions before merge so we can monitor build status before merging.

@ManfredTremmel
Copy link
Author

ManfredTremmel commented Dec 10, 2024

If you need something for testing, I've updated some projects:

@ManfredTremmel
Copy link
Author

Hi @metteo
any idea, when you find the time to check and merge the request? I've ported all my projects and it would be great to release new packages with a new gin dependency.

@metteo
Copy link
Member

metteo commented Jan 20, 2025

Please rebase on master to pull github action.

@metteo
Copy link
Member

metteo commented Jan 20, 2025

Verify checked failed because of some issue with dependency graph even though it worked when merging the action to master.

I'm wondering what's up with the exceptions during test execution. Do you get them locally too?

@ManfredTremmel
Copy link
Author

I had no problems with local builds, but I don't upload any dependency graph.

@ManfredTremmel
Copy link
Author

On https://oss.sonatype.org/content/repositories/snapshots/de/knightsoft-net/gin/4.0.0-SNAPSHOT/ you can find my last snapshot build in my own groupId. I've build it by simply mvn clean deploy

@ManfredTremmel
Copy link
Author

I think this problem is the same as in Github Action Failing When Merging Forks #14, last comment has a possible solution. I'll change the github action in my branch, let's show if it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants