Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed template projects to work without modifications by adding … #507

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

keinhaar
Copy link
Contributor

…eclipse specific files and added project description as tooltip to the combo box

…se specific files and added project description as tooltip to the combo box
@keinhaar keinhaar requested a review from niloc132 January 25, 2025 15:30
@keinhaar
Copy link
Contributor Author

Let's check your scripts ;-)

Copy link
Contributor

@protoism protoism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @keinhaar
Perhaps the new plugin creation logic will need a bit of love.
But it's way better than what we had before.
So... let's go!

<classpath>
<classpathentry kind="src" path="src"/>
<classpathentry kind="con" path="com.gwtplugins.gwt.eclipse.core.GWT_CONTAINER"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if JavaSE-11 is not configured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 11 is required since 2020 to run eclipse. Java 17 since 2022. So there is no compatible eclipse version that does not need java 11.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what Luca is asking is if we can be sure that Java 11 will be installed if 17 is the baseline - 11 may not be installed at all.

Does JavaSE-11 implicitly include all future releases? Java 21 for example has deprecated Java 8 source/target/release, it is reasonable that a future release might drop 11.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaSE-11 is an Execution Environment. It does not mean an exact Java Version. For example in my current Eclipse i run these Applications with Java 17.
At the moment all versions > 11 can be used to run applications with the JavaSE-11 Execution Environment.
I cannot make sure, that Java 30 or Eclipse 2026 will still be compatible, but for now this should be OK.
Anyway, it is a template file. Users could change the required Execution Environment as they need it.

@keinhaar keinhaar merged commit 10cae24 into gwt-plugins:main Feb 10, 2025
1 check passed
@keinhaar keinhaar deleted the tooltips branch February 10, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants