-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External packages #455
Open
gparmer
wants to merge
7
commits into
gwsystems:main
Choose a base branch
from
gparmer:external_packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
External packages #455
Commits on Jun 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8c96044 - Browse repository at this point
Copy the full SHA 8c96044View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdc8978 - Browse repository at this point
Copy the full SHA fdc8978View commit details
Commits on Jun 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f041af4 - Browse repository at this point
Copy the full SHA f041af4View commit details
Commits on Jun 25, 2022
-
Added logic to drive component's compilation path and use github repos.
DONE: 1. Add support for specifying the repo in the composition script, and supporting build-system updates, and validate the previous scripts still work. TODO: 2. Validate that the external repo download and usage works. 3. Update `img` to `src` and enable it to not just have the form of two nested directories (i.e. "x.y"), but also a single subdir (i.e. "x"), or no directory (in the case that a repo is the single component). FUTURE FEATURES: I won't be able to get to these soon, but they are desirable. - Add external library and interface repo support. This is more challenging as it requires more build system logic as dependencies on libraries/interfaces are specified in the build system, not in the composition scripts.
Configuration menu - View commit details
-
Copy full SHA for 1645b07 - Browse repository at this point
Copy the full SHA 1645b07View commit details
Commits on Jun 26, 2022
-
External components can be pulled into the system.
Demonstrated with `external_hello_world.toml`, and the `github.com/gparmer/hello_world/` component. DONE: 1. Add support for specifying the repo in the composition script, and supporting build-system updates, and validate the previous scripts still work. 2. Validate that the external repo download and usage works. TODO: 3. Update `img` to `src` and enable it to not just have the form of two nested directories (i.e. "x.y"), but also a single subdir (i.e. "x"), or no directory (in the case that a repo ish. FUTURE FEATURES: I won't be able to get to these soon, but they are desirable. - Enable the composition scripts to be referenced in github repos, rather than only in local files. - Add external library and interface repo support. This is more challenging as it requires more build system logic as dependencies on libraries/interfaces are specified in the build system, not in the composition scripts.
Configuration menu - View commit details
-
Copy full SHA for 115b8e4 - Browse repository at this point
Copy the full SHA 115b8e4View commit details
Commits on Jun 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ac3bf7a - Browse repository at this point
Copy the full SHA ac3bf7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a04983 - Browse repository at this point
Copy the full SHA 2a04983View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.