Added a new "metastate" section type where one can combine states from different detectors #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eagoetz
changed the title
eagoetz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
+ Coverage 50.29% 50.30% +0.01%
==========================================
Files 60 60
Lines 8665 8699 +34
==========================================
+ Hits 4358 4376 +18
- Misses 4307 4323 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…m different detectors This fixes a problem where the "Quiet" and "Noisy" states were undefined in time, so the whole duration was used. This meant there was no distinction between the states as plotted for the summary pages. A metastate would be defined as ``` [metastate-Quiet] key = Quiet name = SEI Quiet uses = H1-quiet,L1-quiet [state-H1-Quiet] name = SEI Quiet key = H1-quiet hours = 1-5,H1 [state-L1-Quiet] name = SEI Quiet key = L1-quiet hours = 2-6,L1 ``` It is not super robust in that it's really only supposed to be used for combining some interval for H1 and some interval for L1. I'm not sure it's really ready to be heavily used in many situations Addresses the comment in gwpy#358
added 2 commits
March 17, 2023 09:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the "Quiet" and "Noisy" states were undefined in time, so the whole duration was used. This meant there was no distinction between the states as plotted for the summary pages.
A metastate would be defined as
It is not super robust in that it's really only supposed to be used for combining some interval for H1 and some interval for L1. I'm not sure it's really ready to be heavily used in many situations
Addresses the comment in #358