Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove junk radiation before evaluating polarizations #49

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaishakp
Copy link
Collaborator

The current behavior in WaveformModes.get_td_waveform does not allow for removal of junk radiation from the data.

This PR achieves the following:

  1. Removes Junk portion from WaveformModes obj before evaluating polarizations
  2. Allows for a choice of Junk time.

Desirable:

  1. Fetch Junk radiation time from WaveformModes obj

1. Add option to remove junk radiation before evaluating polarizations
and make it default.
2. lint
@vaishakp vaishakp marked this pull request as ready for review September 25, 2024 05:55
@vaishakp
Copy link
Collaborator Author

Tests on GT catalog failing as the reference-time is not the key used in their metadata.

Need to implement retrieving junk time with a uniform attr across catalogs

@vaishakp vaishakp marked this pull request as draft September 25, 2024 06:18
@prayush
Copy link
Contributor

prayush commented Sep 25, 2024

For catalogs that do not provide a reference-time by this or any other name, in simulation/catalog metadata, are those that provide the waveform after removing junk portion of it. Therefore for those catalogs, I suggest initializing reference-time=0 by default for all simulations, unless specifically provided an overriding value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants