Skip to content

Commit

Permalink
ci(code_check): remove exit 1 in error summary check
Browse files Browse the repository at this point in the history
It's useless as errors of previous step already mark the workflow as failed.
And it's confusing by add an error who as no value, say nothing.
  • Loading branch information
gwen-lg committed Feb 8, 2025
1 parent af57761 commit 50b32bd
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/code_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ jobs:
echo "" >> $GITHUB_STEP_SUMMARY
echo "Please check the failed jobs and fix where needed." >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
exit 1
- name: "All checks passed"
if: ${{ success() }}
Expand Down

0 comments on commit 50b32bd

Please sign in to comment.