Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing the FisherSky class to have angle unit suffix rad deg #4992

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

Thomas-JACQUOT
Copy link
Contributor

This PR aims to allow FisherSky class to have angle unit suffix rad deg

Standard information about the request

This is a new feature, which make the FisherSky class able to deal with angle unit suffixes

This change will: change nothing in other parts of the code, it adds only a new feature for the FisherSky class.

Motivation

@titodalcanton, @pannarale and I wanted to change the [prior-ra+dec] section of GRBXXXX.ini files in order to be more clear (see discussion here). To do so, it needs to change the FisherSky class to make it able to deal with angle unit suffixes (just as @titodalcanton did here)

Contents

  • The author of this pull request confirms they will adhere to the code of conduct

@titodalcanton
Copy link
Contributor

titodalcanton commented Dec 16, 2024

After this change, angle_unit will no longer be necessary, so I suggest removing it. I do not think any analysis actually used FisherSky yet, so it should be ok to break backwards compatibility.

Also, you will have to rebase this on master after #4991 is merged for the tests to pass.

Copy link
Contributor

@titodalcanton titodalcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks.

@titodalcanton titodalcanton merged commit 29a53e7 into gwastro:master Dec 17, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants