Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Executable constructor doc #4983

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

pannarale
Copy link
Contributor

The Executable constructor documentation is a bit out of date and this PR is intended to fix it.

This is simply a documentation change.

  • The author of this pull request confirms they will adhere to the code of conduct

@pannarale pannarale added the documentation Updates to documentation label Dec 12, 2024
@pannarale pannarale requested review from ahnitz and spxiwh December 12, 2024 16:48
@pannarale pannarale self-assigned this Dec 12, 2024
Copy link
Contributor

@spxiwh spxiwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some thoughts on the other two options, which is hopefully useful. Just a doc change though, so approved.

pycbc/workflow/core.py Show resolved Hide resolved
pycbc/workflow/core.py Outdated Show resolved Hide resolved
@titodalcanton titodalcanton merged commit bf2fc30 into gwastro:master Dec 19, 2024
28 of 29 checks passed
@pannarale pannarale deleted the Executable_doc branch December 19, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants