Corrected background and module path in pygrb_plot_injs_results #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for slide_id in slide_dict: | ||
| for j, trial in enumerate(trial_dict[slide_id]): | ||
| # True whenever the trigger is in the trial | ||
| trial_cut = (trial[0] <= trig_data[keys[0]][slide_id][:])\ |
There was a problem hiding this comment.
For readability, I suggest defining a temporary variable to hold the value of trig_data[keys[0]][slide_id][:] as the first thing into the outer loop, before entering the loop over trial_dict[slide_id].
titodalcanton
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in #4960 with a module path and it corrects the background. PyGRB background is the collection of max reweighted SNRs, where maximisation is done over each trial. The previous version was gathering all reweighted SNRs and not carrying out this maximisation.
It is the ninth PR in the series started in PR #4929.
Standard information about the request
This is a: 2 bug fixes.
This change affects: PyGRB
This change changes: result presentation / plotting, scientific output