Fix bug in reading single detector event fit_threshold #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titodalcanton
approved these changes
Dec 5, 2024
|
There is a genuine failure in the unit tests (something something attribute not found), please have a look. |
Whatever stat files are being used in the unit test of the pycbc live search must have the fit_threshold stored the old way. That file will need to be updated to make the test pass but I'm not sure where that stat file is stored. |
|
I do not think it is stored anywhere, as far as I remember it is generated on the spot with this script: |
maxtrevor
added a commit
to maxtrevor/pycbc
that referenced
this pull request
Dec 5, 2024
Merged
maxtrevor
added a commit
that referenced
this pull request
Dec 5, 2024
* Fix a couple of output/upload value issues in pycbc live (#4953) * get singles back to being reduced chisquared in uploads * Save ranking statistic information in the "likelihood" part of the coinc table * Not all CandidateForGraceDB will have stat in the coinc_results * Fix bug where single detector event fit_threshold was being read from wrong location (#4971) * Minor increment to version number --------- Co-authored-by: Gareth S Cabourn Davies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fit_thresholdwas being read from the wrong location in an hdf file when computing the significance of single detector events in PyCBC Live.The location it was reading from used to be correct, but was not updated to reflect changes made to pycbc_live_combine_single_significance_fits executable in d486ec2