Save overlapping PSDs with inspiral and use precomputed psds for inspiral #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0. PSD files can either be merge PSD files or files saved as an output of inspiral jobs. 1. Added such option to psd options. If given, this takes precedence. 2. Added class to read those PSD files. This has inspiration from Tito's Time varying class.
ahnitz
requested changes
Nov 7, 2024
|
|
||
|
|
||
| class PrecomputedTimeVaryingPSD(object): | ||
| def __init__(self, opt, length, delta_f, sample_rate): |
There was a problem hiding this comment.
@bhooshan-gadre I think this is a nice way to do this, but I think it might also be useful to be able to invoke this class by hand. Would it not make sense to have a from_cli class method that uses a option/arg input and then a regular init method that could be invoked by hand ?
ahnitz
reviewed
Nov 7, 2024
| err_msg = "No PSDs found intersecting segment!" | ||
| raise ValueError(err_msg) | ||
| fd_segment.psd = best_psd | ||
| if opt.precomputed_psd_file: |
There was a problem hiding this comment.
Wouldn't it make sense to have the precomputed psd be gotten from the pycbc.psd.from_cli method instead? That way it can be invoked more broadly.
tdent
reviewed
Nov 15, 2024
| @@ -26,7 +26,7 @@ def newsnr(snr, reduced_x2, q=6., n=2.): | |||
| reduced chi-squared values. See http://arxiv.org/abs/1208.3491 for | |||
| definition. Previous implementation in glue/ligolw/lsctables.py | |||
| """ | |||
| nsnr = numpy.array(snr, ndmin=1, dtype=numpy.float64) | |||
| nsnr = numpy.array(numpy.abs(snr), ndmin=1, dtype=numpy.float64) | |||
There was a problem hiding this comment.
Is this change needed in the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOP-LEVEL SUMMARY: Save overlapping PSDs with inspiral and use precomputed psds for inspiral
Standard information about the request
This is a new feature and efficiency update
This change may affect but not necessarily if the option is not given: the offline search, PyGRB
This change changes: scientific output
Motivation
Contents
PSD saving code should also be used in the calculate_psd executable. However, I need to understand how to handle MPI parts correctly.
Testing performed