Don't force global multiprocessing start method #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarethCabournDavies
approved these changes
Sep 24, 2024
| @@ -20,7 +20,7 @@ | |||
| import logging | |||
| import numpy | |||
|
|
|||
| from multiprocessing import Pool | |||
There was a problem hiding this comment.
Possibly stupid question - some places have multiprocessing.Pool, other have multiprocessing.pool.Pool. This is how it was before these changes as well, so it must be okay, but wanted to flag it
There was a problem hiding this comment.
If using 'multiprocessing.Pool' I believe this will use default context as defined by 'set_start_method'. In this case one can just use 'get_context("fork/spawn").Pool()'
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* Don't force global multiprocessing start method * code style fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a: bug fix
This change affects library useage of pycbc within a setting where the multiprocessing start context is already set. We currently force a setting of "fork" which doesn't work in some cases and may not be what someone wants for all uses.
Any executable and library code which relies on multiprocessing. In these cases, the correction recommended by @xkzl is used.
This change will ideally have no effect on current usage.
Links to any issues or associated PRs
Error reported in #4853
Testing performed
Additional notes