Further grb utils cleanup #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
approved these changes
Sep 20, 2024
| """Construct a FileList instance containing all segments txt files""" | ||
|
|
||
| seg_dir = workflow.cp.get('workflow', 'segment-dir') | ||
| file_names = ["bufferSeg.txt", "offSourceSeg.txt", "onSourceSeg.txt"] |
There was a problem hiding this comment.
A suggestion here to combine these 3 files into one (these were horrible even in 2011).
There was a problem hiding this comment.
... Probably not for this PR though.
There was a problem hiding this comment.
I opened an issue #4887 for future PyGRB development. Thanks!
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* Removing more resolve_url_to_file calls and commented lines * Fixing typo in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on comments received in, e.g., #4877.
It simply removes the other calls to
resolve_url_to_fileingrb_utils.pyand some remaining commented lines of code. It also fixes a typo in a comment inpycbc_multi_inspiral.This change affects: PyGRB
It was tested in producing this webpage.