allow using constraint in the config which sets vector margin params #4868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahnitz, Can this CC issue be ignored? https://codeclimate.com/github/gwastro/pycbc/pull/4868 |
ahnitz
reviewed
Sep 13, 2024
| @@ -563,7 +563,16 @@ def logprior(self): | |||
| def _logprior(self): | |||
| """Calculates the log prior at the current parameters.""" | |||
| logj = self.logjacobian | |||
| logp = self.prior_distribution(**self.current_params) + logj | |||
| # allow using constraint in the config which sets | |||
There was a problem hiding this comment.
This seems to leak the interface of the marginalization parameters so that it is coded in multiple places. Would it be better to have the DistMarg class perhaps just override this function instead?
There was a problem hiding this comment.
Can you explain more?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a: bug fix
This change affects: inference
This change will: nothing
Motivation
If there are
marginalize_vector_paramsin the config file andconstraintsections to some variables, PyCBC willapply those constraints to those marginalized parameters array, it will show
array-shape mismatch in arrayerror.Contents
Not pass those marginalized parameters to
self.prior_distribution.Links to any issues or associated PRs
Testing performed
Additional notes