added support for mode by mode decomposition of NRHybSur3dq8 waveform model #4516
Conversation
pycbc/waveform/waveform_modes.py
Outdated
| ma = [(l, m) for l in [2, 3, 4] for m in range(-l, l+1)] | ||
| elif approximant.startswith('NRHybSur3dq8'): | ||
| # according to arXiv:1812.07865 | ||
| ma = [(2, 0), (2, 1), (2, 2), (3, 0), (3, 1), (3, 2), |
There was a problem hiding this comment.
What about negative m modes? Should this be similar to above but extending up above but adding in a lone 5, 5 mode?
There was a problem hiding this comment.
There are no negative m supported for this waveform model.
There was a problem hiding this comment.
|
@lpathak97 I just triggered the unittests to run. Can you fix the remaining CC issues though? You can ignore the code duplication one for now, but the others can be fixed. |
|
I have fixed all the issues except duplication. |
|
@lpathak97 You have committed several files that shouldn't be in a repo again. Can you please remove these? |
|
Actually, I was installing it after editing the files. That's why there are so many extra files in the repo. Since there are more than 100 extra files, I would simply delete this branch and make a fresh fork. Then, I will make a PR again. Sorry for the inconvenience. |
No description provided.