Update pycbc_brute_bank to include option to cut wavelength and save … #4506

kkacanja · 2023-09-27T14:41:36Z

…the lower frequency

bin/bank/pycbc_brute_bank

ahnitz · 2023-09-28T15:05:30Z

bin/bank/pycbc_brute_bank

@@ -45,6 +45,8 @@ parser.add_argument('--approximant',  required=True,
 parser.add_argument('--minimal-match', default=0.97, type=float)
 parser.add_argument('--buffer-length', default=2, type=float,
    help='size of waveform buffer in seconds')
+parser.add_argument('--cut-wavelength', type=bool, 
+                    help="Option to cut the wavelength")


More direct help message

The maximum length of a template in seconds

The option should take an argument (the maximum length).

bin/bank/pycbc_brute_bank

Still need to fix the completion percentage

ahnitz · 2023-09-29T17:56:17Z

bin/bank/pycbc_brute_bank

@@ -46,7 +46,9 @@ parser.add_argument('--minimal-match', default=0.97, type=float)
 parser.add_argument('--buffer-length', default=2, type=float,
    help='size of waveform buffer in seconds')
 parser.add_argument('--cut-wavelength', type=bool, 
-                    help="Option to cut the wavelength")
+                    help="When enabled, the program will adjust the wavelength to fit the specified length in max-signal-length ")


We could probably combine these two options, so if max-signal-length isn't given, it doesn't impose any cut.

ahnitz · 2023-09-29T19:04:19Z

@kkacanja Let me know when you want me to review this.

Debugged test example

ahnitz · 2023-10-23T16:01:57Z

bin/bank/pycbc_brute_bank

-                                                f_lower=self.f_lower, **kwds)
-            hp = ws[0]
-            hc = ws[1]
+        flow = numpy.arange(self.f_lower, 100, .1)[::-1]


This line and the next should probably be within the if statement.

ahnitz

@kkacanja Besides for the minor comment which should be straightforward to address, I think this is ready to merge.

ahnitz · 2023-10-24T16:15:24Z

@kkacanja In general, you should use a "rebase" rather than merging master into your code.

kkacanja · 2023-10-24T16:20:19Z

@kkacanja In general, you should use a "rebase" rather than merging master into your code.

Thank you, I am unfamiliar with rebasing so I will do that now.

Condor installation is not working properly for the checks after I changed two lines.

Testing with file used before swapping two lines caused errors

Swapped two lines to be within the if statment

ahnitz · 2023-10-25T19:43:57Z

@kkacanja Some of the tests are fragile to network outages. So for example, if data can't be retrieved when it tries. You have to take a look at the message to see if it looks like this is the case when you see a failure (or if the error seems related to your PR). If it's the former, there should be a button you can click to restart any failed jobs and have them try again. If not, we can walk through this together tomorrow and make sure you have the right permissions set up.

gwastro#4506) * Update pycbc_brute_bank to include option to cut wavelength and save the lower frequency * Removed Logging * Update pycbc_brute_bank Still need to fix the completion percentage * Update pycbc_brute_bank * Update pycbc_brute_bank * Update pycbc_brute_bank Debugged test example * Update pycbc_brute_bank * Update pycbc_brute_bank * Testing Condor Condor installation is not working properly for the checks after I changed two lines. * Testing Testing with file used before swapping two lines caused errors * Update pycbc_brute_bank Swapped two lines to be within the if statment

kkacanja added 2 commits September 26, 2023 16:26

Update pycbc_brute_bank to include option to cut wavelength and save …

17737f0

…the lower frequency

Removed Logging

a4ee467

kkacanja commented Sep 27, 2023

View reviewed changes

bin/bank/pycbc_brute_bank Outdated Show resolved Hide resolved

ahnitz requested changes Sep 28, 2023

View reviewed changes

ahnitz self-requested a review September 28, 2023 18:15

Update pycbc_brute_bank

ff08632

Still need to fix the completion percentage

ahnitz reviewed Sep 29, 2023

View reviewed changes

Update pycbc_brute_bank

039f402

kkacanja added 2 commits October 10, 2023 11:37

Update pycbc_brute_bank

a67bb27

Update pycbc_brute_bank

5afdeba

Debugged test example

ahnitz reviewed Oct 23, 2023

View reviewed changes

ahnitz approved these changes Oct 23, 2023

View reviewed changes

kkacanja added 3 commits October 24, 2023 11:32

Update pycbc_brute_bank

d5e2201

Merge branch 'gwastro:master' into kkacanja-patch-1

7db868a

Update pycbc_brute_bank

58a908c

kkacanja added 3 commits October 24, 2023 13:55

Testing Condor

cc8de9b

Condor installation is not working properly for the checks after I changed two lines.

Testing

82e4b21

Testing with file used before swapping two lines caused errors

Update pycbc_brute_bank

050c915

Swapped two lines to be within the if statment

ahnitz merged commit 0f279ba into gwastro:master Oct 25, 2023
31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update pycbc_brute_bank to include option to cut wavelength and save … #4506

Update pycbc_brute_bank to include option to cut wavelength and save … #4506

kkacanja commented Sep 27, 2023

ahnitz Sep 28, 2023

ahnitz Sep 29, 2023

ahnitz commented Sep 29, 2023

ahnitz Oct 23, 2023

ahnitz left a comment

ahnitz commented Oct 24, 2023

kkacanja commented Oct 24, 2023

ahnitz commented Oct 25, 2023

Update pycbc_brute_bank to include option to cut wavelength and save … #4506

Update pycbc_brute_bank to include option to cut wavelength and save … #4506

Conversation

kkacanja commented Sep 27, 2023

ahnitz Sep 28, 2023

Choose a reason for hiding this comment

ahnitz Sep 29, 2023

Choose a reason for hiding this comment

ahnitz commented Sep 29, 2023

ahnitz Oct 23, 2023

Choose a reason for hiding this comment

ahnitz left a comment

Choose a reason for hiding this comment

ahnitz commented Oct 24, 2023

kkacanja commented Oct 24, 2023

ahnitz commented Oct 25, 2023