Add option to skip generator caching #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WuShichao
approved these changes
May 22, 2024
| log_mf_min = int(math.log(f_min*MTSUN_SI*(m1+m2)) * 25) | ||
|
|
||
| wave_gen = get_waveform_genner(log_mf_min, run_phenomd=run_phenomd) | ||
| log_mf_min = math.log(f_min*MTSUN_SI*(m1+m2)) * 25 |
There was a problem hiding this comment.
Thanks for the PR! Why do you remove int()? Previously, we used it to round down.
| if cache_generator: | ||
| # Use int to round down | ||
| wave_gen = cached_get_waveform_genner( | ||
| int(log_mf_min), |
There was a problem hiding this comment.
Ah, OK, you moved it here.
spxiwh
reviewed
May 24, 2024
| @@ -129,6 +134,7 @@ def _bbhx_fd( | |||
| direct=False, | |||
| num_interp=100, | |||
| interp_f_lower=1e-4, | |||
| cache_generator=True, | |||
There was a problem hiding this comment.
I would suggest to make the default False. Easier to avoid issues if the user has to "opt-in" to use this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some discussion with @spxiwh, I wanted to add an option to disable the generator caching. For now, I've taken the simple approach of having two functions but I'm open to suggestions for how to best do this.
I've also added a test to ensure the cache is still called correctly.