Formatting, type issues and example edit. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes with issue fix #17 and fix #14.
The code is now formatted with dartfmt and the tests are passing. This can might bring the maximum pub points to the package.
Also, the
JwtDecoder.isExpiredmethod can now work even though theiator theexpclaims are present as strings. This is useful when you are using a JWT library that generates the token with String claims. (Specify in documentation that token's payload must include "iat" and "exp" fields. #17)Also, @gustavo0197, please do consider closing #11 and #12 after updating the release on pub.dev.
Regards :)