Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support STP and Yices2 #400

Merged
merged 23 commits into from
Dec 15, 2023
Merged

Support STP and Yices2 #400

merged 23 commits into from
Dec 15, 2023

Conversation

vcanumalla
Copy link
Collaborator

@vcanumalla vcanumalla commented Nov 29, 2023

This PR adds support for STP and Yices2 to improve our portfolio solving.

It adds

  • Match arm branches of solver flag parsing inmain.rkt that allows the user to pass in STP or Yices2 as the solver.
  • Lines in the lakeroad-portfolio.py that add stp and yices2 as options for portfolio solving.

Note that this PR doesn't add functionality for passing flags/solver settings to STP or Yices2; we haven't needed them yet.

Closes #406

@gussmith23
Copy link
Owner

gussmith23 commented Nov 29, 2023

Great work. There's one more thing that needs to be done, and that's getting STP support into Rosette. We have two options here:

  1. Open a PR on Rosette and get it merged before merging this PR, or
  2. Add modified Rosette (with STP support) as a submodule to Lakeroad. This would also require updating the Dockerfile so that it installs Rosette from the submodule.

Given that we want to get STP and Yices2 support into Rosette anyway, I say we take option 1. This means that you should prioritize opening up the STP and Yices2 PR on Rosette ASAP so that we can get their CI working. I suspect they'll be happy to merge after that. This PR will be blocked until they merge.

This looks really good! I especially appreciate the detailed PR message.

@gussmith23 gussmith23 changed the title Add Option for STP Support STP and Yices2 Dec 14, 2023
@gussmith23
Copy link
Owner

Had to manually rerun tests and force total rebuild so that new Rosette got pulled. That manual rerun passed, so merging now.

@gussmith23 gussmith23 merged commit e0d02d2 into main Dec 15, 2023
7 of 8 checks passed
@gussmith23 gussmith23 deleted the vcanumalla/support-stp branch December 15, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert some tests towards using Yices2 and STP
2 participants