Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle singer decimal and datetime data types #26

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Conversation

avadag
Copy link
Contributor

@avadag avadag commented Feb 6, 2023

I've updated the code to handle the singer.decimal data type as well as date-time, raw, and blob

@avadag avadag requested a review from a team as a code owner February 6, 2023 19:42
@ndrluis
Copy link
Member

ndrluis commented May 4, 2023

Hello @avadag, thank you for your contribution.

Could you please add some tests for the implementation you made?

The test file is https://github.com/gupy-io/target-s3-parquet/blob/main/target_s3_parquet/tests/test_data_type_generator.py.

@avadag
Copy link
Contributor Author

avadag commented Jun 15, 2023

@ndrluis yes, I just added some tests, thank you!

ndrluis
ndrluis previously approved these changes Jun 27, 2023
@ndrluis ndrluis merged commit 0292db6 into gupy-io:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants