Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loop over nBin not starting from 1 like TH1D #706

Merged
merged 1 commit into from
Nov 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
probably found the bug: loop over nBin not starting from 1 like TH1D
  • Loading branch information
nadrino committed Nov 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 18d8315a2a8ecb6b506be25582a7d57d0f88ccce
2 changes: 1 addition & 1 deletion src/Fitter/Minimizer/src/RootMinimizer.cpp
Original file line number Diff line number Diff line change
@@ -285,7 +285,7 @@ void RootMinimizer::minimize(){
samplesArrList[iSample].writeRawData( getLikelihoodInterface().evalStatLikelihood( samplePair ) );

int nBins = samplePair.model->getHistogram().getNbBins();
for( int iBin = 1 ; iBin <= nBins ; iBin++ ){
for( int iBin = 0 ; iBin < nBins ; iBin++ ){
leavesDict.emplace_back("llhSample_bin" + std::to_string(iBin) + "/D");
samplesArrList[iSample].writeRawData( getLikelihoodInterface().getJointProbabilityPtr()->eval(samplePair, iBin) );
}
Original file line number Diff line number Diff line change
@@ -104,6 +104,14 @@ namespace JointProbability{
<< std::endl;
LogError << "nomMC bin " << bin_
<< " error is " << nomHistErr[bin_];

DEBUG_VAR(bin_);
DEBUG_VAR(mcuncert);
DEBUG_VAR(nomHistErr[bin_]);
DEBUG_VAR(nomHistErr.size());
DEBUG_VAR(nomHistErr.size());
DEBUG_VAR(GenericToolbox::toString(nomHistErr));

LogThrow("The mc uncertainty is not a usable number");
}
else{