Bugfix/inconsistent VAST loading #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes VAST/VPAID inconsistent loading. I think this happened because we didn't replace the
[timestamp]macro from the VAST URLs, and ad servers don't seem to like this.After replacing the macro, this issue seems to be gone.
Additionally, for easier debugging, I improved the demo page so that sources can be changed dynamically now.
The player will now get the BaseURL from the last gg-ez-vp.js script it finds instead of throwing an error when there is more than one script, but this is just a temporary fix while #63 is fixed.