Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposition to include language names #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nico-Duduf
Copy link

I've added this for some of my projects, thought it may be useful; it's not a big overweight but helps to quickly setup language selectors.

The language names are localized instead of English, that makes more sense in UIs, and use the "menu" variant (for better alphabetical sorting).

If you think it's too large to be included, I understand ;)

I've added this for some of my projects, thought it may be useful; it's not a big overweight but helps to quickly setup language selectors.

The language names are localized instead of English, that makes more sense in UIs, and use the "menu" variant (for better alphabetical sorting).

If you think it's too large to be included, I understand ;)
@guillaumepotier
Copy link
Owner

Hi Nicolas,

Thank you for this pull request and your usage of gettext ;)

As you suspected, the main interest of this lib (against the many others that exist out there) is to be very lightweight and efficient for translating strings frontend. I still think its sole purpose should be only translating, and not in some way help with UI or other things.

That being said, I'm not against shipping some extensions / tools alongside gettext.js if some users find any interest in them. Maybe you should package your logic in a separate file that would decorate gettextjs to add these methods and languages ?

Hope that trade-off would suit you ;)

A bientôt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants