Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tch and torch-sys from 0.13.0 to 0.14.0 #426

Closed
wants to merge 3 commits into from
Closed

update tch and torch-sys from 0.13.0 to 0.14.0 #426

wants to merge 3 commits into from

Conversation

OhMyVolk
Copy link

@OhMyVolk OhMyVolk commented Oct 6, 2023

Tested locally using cargo test --features hf-tokenizers onnx with both CPU and GPU versions of libtorch 2.1.0.

System specs:
OS: Linux
Distro: Manjaro
Kernel version: 6.1.53

@OhMyVolk OhMyVolk mentioned this pull request Nov 21, 2023
Closed
@brianm
Copy link

brianm commented Nov 21, 2023

bump?

@guillaume-be guillaume-be mentioned this pull request Nov 21, 2023
Closed
@guillaume-be
Copy link
Owner

Unfortunately the latest version of tch causes error when loading models that have been saved in half precision on a CPU (the CI for this PR is failing). I have raised an issue in the upstream repository (see LaurentMazare/tch-rs#805) but this has not yet been addressed.

@guillaume-be
Copy link
Owner

Thank you @volking0 for opening this. Unfortunately the migration to 0.14.0 was a bit more involved and required a more careful handling of model weights casting. I have made these changes in #435 , including the migration to 0.14.0. Closing this as it is no longer needed - please let me know if you are still facing issues on Arch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OhMyVolk @brianm @guillaume-be