feat: make enableServiceLinks configurable (#118)

Signed-off-by: Lester Guerzon <[email protected]>
guerzon · Sep 7, 2024 · 46c7e41 · 46c7e41
1 parent 527440a
commit 46c7e41
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 1 deletion.
diff --git a/charts/vaultwarden/Chart.yaml b/charts/vaultwarden/Chart.yaml
@@ -13,5 +13,5 @@ maintainers:
   - name: guerzon
     email: [email protected]
     url: https://github.com/guerzon
-version: 0.27.0
+version: 0.28.0
 kubeVersion: ">=1.12.0-0"
diff --git a/charts/vaultwarden/README.md b/charts/vaultwarden/README.md
@@ -338,6 +338,7 @@ helm -n $NAMESPACE uninstall $RELEASE_NAME
 | `podSecurityContext`    | Pod security options                                                                      | `{}`                 |
 | `securityContext`       | Default security options to run vault as read only container without privilege escalation | `{}`                 |
 | `dnsConfig`             | Pod DNS options                                                                           | `{}`                 |
+| `enableServiceLinks`    | Enable service links, Kubernetes default is true                                          | `true`               |
 
 ### Reliability configuration
 

diff --git a/charts/vaultwarden/ci/test-values.yaml b/charts/vaultwarden/ci/test-values.yaml
@@ -24,3 +24,5 @@ duo:
   iKey: "999888"
   sKey:
     value: "HELLO"
+
+enableServiceLinks: false
diff --git a/charts/vaultwarden/templates/_podSpec.tpl b/charts/vaultwarden/templates/_podSpec.tpl
@@ -23,6 +23,9 @@ securityContext:
 initContainers:
 {{- toYaml . | nindent 2 }}
 {{- end }}
+{{- if not .Values.enableServiceLinks }}
+enableServiceLinks: false
+{{- end }}
 containers:
   - image: {{ .Values.image.registry }}/{{ .Values.image.repository }}:{{ .Values.image.tag }}
     imagePullPolicy: {{ .Values.image.pullPolicy }}

diff --git a/charts/vaultwarden/values.yaml b/charts/vaultwarden/values.yaml
@@ -124,6 +124,11 @@ securityContext:
 ## Ref: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config
 dnsConfig: {}
 
+## @param enableServiceLinks Enable service links, Kubernetes default is true
+## Ref: https://kubernetes.io/docs/tutorials/services/connect-applications-service/#accessing-the-service
+##
+enableServiceLinks: true
+
 ## @section Reliability configuration
 ##