Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuardianAdLite: Add Landing Page poster image #6782

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Feb 13, 2025

What are you doing in this PR?

Inserts (guim optimised) poster image onto Guardian Ad-Lite Landing Page

Trello Card

Screenshots

before after
image image

@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team February 13, 2025 18:17
Copy link
Contributor

github-actions bot commented Feb 13, 2025

Size Change: 0 B

Total Size: 1.9 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.4 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.6 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB
./public/compiled-assets/javascripts/error404Page.js 67.3 kB
./public/compiled-assets/javascripts/error500Page.js 67.2 kB
./public/compiled-assets/javascripts/favicons.js 617 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 73.6 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 78 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB
./public/compiled-assets/webpack/114.js 12.2 kB
./public/compiled-assets/webpack/127.js 3.53 kB
./public/compiled-assets/webpack/136.js 2.17 kB
./public/compiled-assets/webpack/163.js 8.9 kB
./public/compiled-assets/webpack/187.js 20 kB
./public/compiled-assets/webpack/192.js 5.69 kB
./public/compiled-assets/webpack/276.js 4.39 kB
./public/compiled-assets/webpack/344.js 2 kB
./public/compiled-assets/webpack/445.js 6.94 kB
./public/compiled-assets/webpack/492.js 7.58 kB
./public/compiled-assets/webpack/503.js 37.7 kB
./public/compiled-assets/webpack/706.js 107 kB
./public/compiled-assets/webpack/719.js 13.5 kB
./public/compiled-assets/webpack/847.js 26 kB
./public/compiled-assets/webpack/checkout.js 17 kB
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.15 kB
./public/compiled-assets/webpack/LandingPage.js 15.5 kB
./public/compiled-assets/webpack/oneTimeCheckout.js 6.16 kB
./public/compiled-assets/webpack/ThankYou.js 44.5 kB

compressed-size-action

@paul-daniel-dempsey paul-daniel-dempsey changed the title Guardian Ad-Lite: Add Landing Page poster image GuardianAdLite: Add Landing Page poster image Feb 13, 2025
Copy link
Member

@tjmw tjmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The image looks a little blocky on a high pixel density screen to me. I can't tell if that's an intentional part of the design or if a higher res image would be better. The original in the Grid is quite small, do you know where that came from?

@paul-daniel-dempsey
Copy link
Contributor Author

👍

The image looks a little blocky on a high pixel density screen to me. I can't tell if that's an intentional part of the design or if a higher res image would be better. The original in the Grid is quite small, do you know where that came from?

Agree, think its by design, its the original size PNG from the figma design link Shraddha pointed me too here. Can revisit if necessary would guess.

@paul-daniel-dempsey paul-daniel-dempsey merged commit 4b25aed into main Feb 14, 2025
19 checks passed
@paul-daniel-dempsey paul-daniel-dempsey deleted the pd/guardian-adlite-landing-images branch February 14, 2025 09:32
@prout-bot
Copy link

Seen on PROD (merged by @paul-daniel-dempsey 9 minutes and 50 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants