Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Editions: Subscribe Landing Page ab-test simplification #6775

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Feb 12, 2025

What are you doing in this PR?

ABTest: digitalEditionCheckout ->

  • Remove non-required use of canRun
  • Replace with persistsPage instead.

@paul-daniel-dempsey paul-daniel-dempsey changed the title feat: simplify abtest canrun using persistPage Digital Editions: Subscribe Landing Page ab-test simplification Feb 12, 2025
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Size Change: -368 B (-0.02%)

Total Size: 1.9 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.4 kB -27 B (-0.03%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.6 kB -39 B (-0.04%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB +1 B (0%)
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB -37 B (-0.02%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB +1 B (0%)
./public/compiled-assets/javascripts/error404Page.js 67.3 kB +1 B (0%)
./public/compiled-assets/javascripts/error500Page.js 67.2 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB -44 B (-0.03%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB -28 B (-0.03%)
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.6 kB -27 B (-0.04%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 78 kB -32 B (-0.04%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB -37 B (-0.03%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB -42 B (-0.03%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB -29 B (-0.03%)
./public/compiled-assets/webpack/114.js 12.2 kB 0 B
./public/compiled-assets/webpack/127.js 3.53 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/163.js 8.9 kB 0 B
./public/compiled-assets/webpack/187.js 20 kB -29 B (-0.14%)
./public/compiled-assets/webpack/192.js 5.69 kB 0 B
./public/compiled-assets/webpack/276.js 4.39 kB 0 B
./public/compiled-assets/webpack/344.js 2 kB 0 B
./public/compiled-assets/webpack/445.js 6.94 kB 0 B
./public/compiled-assets/webpack/492.js 7.58 kB 0 B
./public/compiled-assets/webpack/503.js 37.7 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/719.js 13.5 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/checkout.js 17 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.15 kB 0 B
./public/compiled-assets/webpack/LandingPage.js 15.5 kB 0 B
./public/compiled-assets/webpack/oneTimeCheckout.js 6.16 kB 0 B
./public/compiled-assets/webpack/ThankYou.js 44.5 kB 0 B

compressed-size-action

@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team February 12, 2025 15:02
Copy link
Member

@tjmw tjmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I left some really nitpicky comments on the regex to take or leave.

@paul-daniel-dempsey paul-daniel-dempsey merged commit 0cf4197 into main Feb 13, 2025
19 checks passed
@paul-daniel-dempsey paul-daniel-dempsey deleted the pd/digital-editions-landing-page-abtest branch February 13, 2025 10:30
@prout-bot
Copy link

Seen on PROD (merged by @paul-daniel-dempsey 10 minutes ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants