Fetch landing page config from dynamodb #6772
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.91 MB ℹ️ View Unchanged
|
tomrf1
commented
Feb 12, 2025
| } | ||
|
|
||
| object LandingPageTestService { | ||
| // Converts Dynamodb Attributes to Circe Json |
There was a problem hiding this comment.
tomrf1
commented
Feb 12, 2025
| @@ -53,43 +53,3 @@ object LandingPageTest { | |||
| implicit val encoder: Encoder[LandingPageTest] = deriveEncoder | |||
| implicit val decoder: Decoder[LandingPageTest] = deriveDecoder | |||
| } | |||
|
|
|||
| // TODO - fetch config from dynamodb instead of hardcoding here | |||
| object LandingPageTestsProvider extends SettingsProvider[List[LandingPageTest]] { | |||
There was a problem hiding this comment.
there's still a hardcoded fallback in the client, in case something goes wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we hardcoded the landing page tests config into the backend.
Now that we have a dynamodb table with this config, we can remove this.
This PR introduces the
LandingPageTestServicefor polling and caching the dynamodb data.It also adds a new alarm (based on a cloudwatch metric) to tell us when the server fails to fetch or parse a landing page test from Dynamodb. Note that even if only one test config is invalid, and the rest are successfully returned to the client, the alarm will still trigger.