Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuardianAdLite: Stop SignedIn Ad-Free Users from re-purchasing Guardian Ad-Lite #6769

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Feb 11, 2025

What are you doing in this PR?

Stops SignedIn Ad-Free Users from re-purchasing Guardian Ad-Lite
Different messages dependent on Sign-In status (see CODE screenshot's below)

Trello Card

How to test

  1. Login through CODE MMA (Ad-Lite or Ad-Free User)
  2. Goto Guardian Ad-Lite Checkout,
  3. Checkout (will get error message show below)
  4. Sign-Out
  5. Repeat Checkout with same email address (just not-signed in)

Screenshots

Not Signed-In Sign-In
image image

@paul-daniel-dempsey paul-daniel-dempsey changed the title feat: GuardianAdLite SignedIn Bypass Remove GuardianAdLite: Stop SignedIn Ad-Free Users from re-purchasing Ad-Free Feb 11, 2025
@paul-daniel-dempsey paul-daniel-dempsey changed the title GuardianAdLite: Stop SignedIn Ad-Free Users from re-purchasing Ad-Free GuardianAdLite: Stop SignedIn Ad-Free Users from re-purchasing Guardian Ad-Lite Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Size Change: +103 B (+0.01%)

Total Size: 1.9 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.4 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.6 kB 0 B
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB +22 B (+0.01%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 67.3 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 67.2 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB +20 B (+0.01%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.6 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 78 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB +21 B (+0.02%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB +20 B (+0.01%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB 0 B
./public/compiled-assets/webpack/114.js 12.2 kB 0 B
./public/compiled-assets/webpack/127.js 3.53 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/163.js 8.9 kB 0 B
./public/compiled-assets/webpack/187.js 20 kB 0 B
./public/compiled-assets/webpack/192.js 5.69 kB 0 B
./public/compiled-assets/webpack/276.js 4.39 kB 0 B
./public/compiled-assets/webpack/344.js 2 kB 0 B
./public/compiled-assets/webpack/445.js 6.94 kB 0 B
./public/compiled-assets/webpack/492.js 7.58 kB 0 B
./public/compiled-assets/webpack/503.js 37.7 kB +20 B (+0.05%)
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/719.js 13.5 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/checkout.js 17 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.15 kB 0 B
./public/compiled-assets/webpack/LandingPage.js 15.5 kB 0 B
./public/compiled-assets/webpack/oneTimeCheckout.js 6.16 kB 0 B
./public/compiled-assets/webpack/ThankYou.js 44.5 kB 0 B

compressed-size-action

@paul-daniel-dempsey paul-daniel-dempsey requested review from tjmw and a team and removed request for tjmw February 11, 2025 14:37
@tjmw
Copy link
Member

tjmw commented Feb 12, 2025

The error message we're showing here has the text please sign in, but the user is already signed in. I wonder if there's some alternative copy we could use for these users.

@paul-daniel-dempsey
Copy link
Contributor Author

The error message we're showing here has the text please sign in, but the user is already signed in. I wonder if there's some alternative copy we could use for these users.

Yes, we removed sign in part if the user was signed in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants