Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Editions: Ts&Cs align copy to original LandingPage #6761

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Feb 6, 2025

What are you doing in this PR?

Copies the Ts&C's from the existing DigitalEdition LandingPage and places them in sam location on the new generic checkout when purchasing a DigitalSubscription.

Mis-matching Ts&Cs between the original DigitalEditionLandingPage and the generic checkout.

  1. Align Ts&Cs
  2. Remove un-required SummaryTsAndCs
  3. Fixed format (half width) bug for TierThree TsAndCs

Trello Card

How to test

Original->
https://support.thegulocal.com/uk/subscribe/digitaledition
New->
https://support.thegulocal.com/uk/checkout?product=DigitalSubscription&ratePlan=Monthly
https://support.thegulocal.com/uk/checkout?product=DigitalSubscription&ratePlan=Annual

Screenshots

Original New (Monthly) New (Annual)
image image image

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Size Change: -639 B (-0.03%)

Total Size: 1.89 MB

Filename Size Change
./public/compiled-assets/webpack/969.js 0 B -37.8 kB (removed) 🏆
./public/compiled-assets/webpack/953.js 37.3 kB +37.3 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.3 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.4 kB -64 B (-0.07%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 222 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 67.3 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 67.2 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB -26 B (-0.02%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.5 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 72.9 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB 0 B
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB -32 B (-0.02%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB 0 B
./public/compiled-assets/webpack/114.js 12.2 kB 0 B
./public/compiled-assets/webpack/127.js 3.53 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/163.js 8.9 kB 0 B
./public/compiled-assets/webpack/187.js 20 kB 0 B
./public/compiled-assets/webpack/192.js 5.69 kB 0 B
./public/compiled-assets/webpack/276.js 4.39 kB 0 B
./public/compiled-assets/webpack/344.js 2 kB 0 B
./public/compiled-assets/webpack/445.js 6.93 kB 0 B
./public/compiled-assets/webpack/492.js 7.58 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/719.js 13.5 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/checkout.js 17.2 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.26 kB 0 B
./public/compiled-assets/webpack/LandingPage.js 15.5 kB 0 B
./public/compiled-assets/webpack/oneTimeCheckout.js 6.07 kB 0 B
./public/compiled-assets/webpack/ThankYou.js 44.5 kB 0 B

compressed-size-action

@paul-daniel-dempsey paul-daniel-dempsey changed the title Pd/digital editions tsandcs Digital Editions: Ts&Cs align copy with original LandingPage Feb 6, 2025
@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team February 6, 2025 18:02
@paul-daniel-dempsey paul-daniel-dempsey changed the title Digital Editions: Ts&Cs align copy with original LandingPage Digital Editions: Ts&Cs align copy to original LandingPage Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant