Add server side validation for billing address postcode #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had an ongoing issue where requests where the payment method is PayPal make it to support workers with an email address in the billing postcode field. We're not sure why this happens but are hoping some server side validation will prevent it and alert users that they need to fix something. It primarily seems to affect USD Supporter Plus and recurring contributions (we collect the postcode for these) so I've focused on fixing those cases, in the PaidProductValidation object used by both products. I've introduced a concept of a preservable error message, i.e. something we can map to copy to show the user. It'd be nice to extend this but for now it's a one off for this field. As it stands, it's not perfect - if there are other validation errors we'll lose the message. I'd like to fix that in a future PR.
|
Size Change: +237 B (+0.01%) Total Size: 1.89 MB ℹ️ View Unchanged
|
| @@ -102,6 +112,7 @@ object CheckoutValidationRules { | |||
| case _: Contribution => PaidProductValidation.passes(createSupportWorkersRequest) | |||
| case _: GuardianAdLite => PaidProductValidation.passes(createSupportWorkersRequest) | |||
| }) match { | |||
| case Invalid(message) if PreservableErrorMessages.isMessagePreservable(message) => Invalid(message) | |||
There was a problem hiding this comment.
Presume this converts to a invalidPostCode message to be picked up in errorReasons.tsx later
| @@ -393,6 +393,13 @@ class PaidProductValidationTest extends AnyFlatSpec with Matchers { | |||
| PaidProductValidation.passes(requestSupporterPlus) shouldBe Valid | |||
| } | |||
|
|
|||
| it should "fail if the billing postcode field contains an email address" in { | |||
There was a problem hiding this comment.
Thanks for help getting tests running, works great with @
| ) | ||
| ) and | ||
| // For products which use this validation, we only collect postal/zip code in the US | ||
| hasValidBillingPostcodeCharacters(createSupportWorkersRequest.billingAddress.postCode) |
There was a problem hiding this comment.
Great Comment, presume this limits to the US postcodes only
paul-daniel-dempsey
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Add server side validation for billing address postcode.
Trello Card
Why are you doing this?
We've had an ongoing issue where requests where the payment method is PayPal make it to support workers with an email address in the billing postcode field. We're not sure why this happens but are hoping some server side validation will prevent it and alert users that they need to fix something. It primarily seems to affect USD Supporter Plus and recurring contributions (we collect the postcode for these) so I've focused on fixing those cases, in the PaidProductValidation object used by both products.
I've introduced a concept of a preservable error message, i.e. something we can map to copy to show the user. It'd be nice to extend this but for now it's a one off for this field. As it stands, it's not perfect - if there are other validation errors we'll lose the message. I'd like to fix that in a future PR.
Note: The error message copy needs updating.Copy has been updated.How to test
Entering something which looks like an email address (contains an
@character) triggers the validation:How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots