Remove some cookies set by the checkout #6714
Merged
+94
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.9 MB ℹ️ View Unchanged
|
rupertbates
reviewed
Feb 7, 2025
| ) | ||
| case _: SupporterPlus | _: TierThree | _: DigitalPack => | ||
| List(SessionCookie("GU_AF1", now.plusDays(1).getMillis.toString)) | ||
|
|
||
| case p: Paper if p.productOptions.hasDigitalSubscription => |
There was a problem hiding this comment.
I know this is pre-existing but we give ad-free to all paper subscribers now, not just those with the digipack add on
rupertbates
reviewed
Feb 11, 2025
| Accepted(createSubscriptionResponse.asJson) | ||
| .withCookies(cookies: _*) | ||
| .discardingCookies(discardIncompleteCheckoutCookie), | ||
| result.value.flatMap { |
There was a problem hiding this comment.
I refactored this because there was a warning about nested stateful monads. I think it looks clearer this way as well.
I've removed the following as they're no longer used: * gu_recurring_contributor * gu_digital_subscriber * gu.contributions.recurring.contrib-timestamp.<billing period> I've refactored the cookie setting code a bit to consolidate things and make it clear where products set the same cookie(s).
rupertbates
force-pushed
the
tw/remove-cookies-set-by-checkout
branch
from
44f1c56 to
9f2357c
Compare
…emove-cookies-set-by-checkout
rupertbates
approved these changes
Feb 12, 2025
tjmw
commented
Feb 12, 2025
|
Seen on PROD (created by @tjmw and merged by @rupertbates 9 minutes and 51 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
I've removed the following as they're no longer needed:
gu_recurring_contributorgu_digital_subscribergu.contributions.recurring.contrib-timestamp.<billing period>I've refactored the cookie setting code a bit to consolidate things and make it clear where products set the same cookie(s).
Trello Card
Why are you doing this?
These cookies are no longer needed.
How to test
Put through a purchase, see that these cookies are no longer set.