update after including merch high position changes

guardian · Jan 16, 2025 · 8496f75 · 8496f75
1 parent 0734082
commit 8496f75
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/dotcom-rendering/src/lib/getFrontsAdPositions.test.ts b/dotcom-rendering/src/lib/getFrontsAdPositions.test.ts
@@ -254,13 +254,13 @@ describe('Mobile Ads', () => {
 			{
 				collectionType: 'scrollable/feature',
 				containerLevel: 'Secondary',
-			}, // Ad position (21)
+			}, // Ignored - is merch high position
 			{ collectionType: 'news/most-popular' }, // Ignored - is most viewed container
 		];
 
 		const mobileAdPositions = getMobileAdPositions(testCollections);
 
-		expect(mobileAdPositions).toEqual([0, 4, 6, 8, 10, 14, 19, 21]);
+		expect(mobileAdPositions).toEqual([0, 4, 6, 8, 10, 14, 19]);
 	});
 });
 

diff --git a/dotcom-rendering/src/lib/getFrontsAdPositions.ts b/dotcom-rendering/src/lib/getFrontsAdPositions.ts
@@ -100,7 +100,7 @@ const isEvenIndex = (_collection: unknown, index: number): boolean =>
  * up to a maximum of `MAX_FRONTS_MOBILE_ADS`
  */
 const getMobileAdPositions = (collections: AdCandidate[]): number[] => {
-	const merchHighPosition = getMerchHighPosition(collections.length);
+	const merchHighPosition = getMerchHighPosition(collections);
 	const hasSecondaryContainers = hasSecondaryLevelContainers(collections);
 
 	return (