Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump content-entity's latest release #169

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Mar 26, 2024

We have got latest release of content-entity after implementing gha-scala-library-release
This PR will bump that version and test as well.

@Divs-B Divs-B requested review from a team as code owners March 26, 2024 17:42
@gu-scala-library-release
Copy link
Contributor

@Divs-B has published a preview version of this PR with release workflow run #13, based on commit cb6c4e6:

4.0.2-PREVIEW.db-rttest-content-entity-release.2024-03-26T1749.cb6c4e64

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the db-rt/test-content-entity-release branch, or use the GitHub CLI command:

gh workflow run release.yml --ref db-rt/test-content-entity-release

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@Divs-B
Copy link
Contributor Author

Divs-B commented Mar 27, 2024

We have tested preview release in content-api-model which later has got tested in apple-news .
all working as expected.
image

Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

To save you a bit of time, I'll merge this and generate a new release...

@rtyley rtyley merged commit 1f8c097 into main Mar 27, 2024
9 checks passed
@rtyley
Copy link
Member

rtyley commented Mar 27, 2024

Oh no :( the release process failed for Sonatype:

image

2024-03-27 14:33:57.077Z error [Sonatype] 
wvlet.airframe.http.HttpClientException: [401: Unauthorized]
	at wvlet.airframe.http.HttpClientException$.requestFailure(HttpClientException.scala:72)
	at wvlet.airframe.http.HttpClientException$.classifyHttpResponse(HttpClientException.scala:119)
	at wvlet.airframe.http.client.HttpClients$.$anonfun$baseHttpClientRetry$1(HttpClients.scala:43)
	at wvlet.airframe.control.Retry$RetryContext.classifyResult(Retry.scala:268)
	at wvlet.airframe.control.Retry$RetryContext.$anonfun$runAsyncWithContext$3(Retry.scala:3[30](https://github.com/guardian/content-atom/actions/runs/8453474431/job/23156437974#step:5:31))
	at wvlet.airframe.rx.RxRunner.$anonfun$run$16(RxRunner.scala:233)
	at scala.util.Try$.apply(Try.scala:213)

I've not seen a failure at that point for quite some time... obviously, it's not the fault of this PR, but tidying it up will be a bit tiresome due to the guardian/gha-scala-library-release-workflow#33 problem.

I'll try publishing a different project, to see if that succeeds.

@rtyley
Copy link
Member

rtyley commented Mar 27, 2024

So releasing etag-caching worked fine:

image

...I think this might mean that the release failure here is just Sonatype being flakey?? I will try doing a new release on content-atom.

@rtyley
Copy link
Member

rtyley commented Mar 27, 2024

A second attempt at release succeeded, with no significant changes to the content-atom repo at all:

image

...so I guess it was just Sonatype being flakey (which isn't great...!).

Surprisingly, despite guardian/gha-scala-library-release-workflow#33, I didn't have to disable compatibility checking - as it was already absent! We need to add that back in...

@Divs-B
Copy link
Contributor Author

Divs-B commented Mar 27, 2024

Thanks @rtyley for checking the release. It does looks like i missed adding compatiblity check when adopting release process. will do it in the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants