Skip to content

Commit

Permalink
Merge pull request #161 from guardian/remove-recipe-atom
Browse files Browse the repository at this point in the history
Remove deprecated recipe atom
  • Loading branch information
rowannekabalan authored Nov 8, 2023
2 parents d26c7f7 + 0840bdb commit c334e99
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 73 deletions.
1 change: 0 additions & 1 deletion js/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ exports.interactiveTypes = require('../generated/gen-nodejs/interactive_types')
exports.mediaTypes = require('../generated/gen-nodejs/media_types');
exports.quizTypes = require('../generated/gen-nodejs/quiz_types');
exports.reviewTypes = require('../generated/gen-nodejs/review_types');
exports.recipeTypes = require('../generated/gen-nodejs/recipe_types');
exports.shared = require('../generated/gen-nodejs/shared_types');
exports.chartAtom = require('../generated/gen-nodejs/chartatom_types');
67 changes: 0 additions & 67 deletions thrift/src/main/thrift/atoms/recipe.thrift

This file was deleted.

9 changes: 4 additions & 5 deletions thrift/src/main/thrift/contentatom.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ include "atoms/interactive.thrift"
include "atoms/profile.thrift"
include "atoms/qanda.thrift"
include "atoms/review.thrift"
include "atoms/recipe.thrift"
include "atoms/timeline.thrift"
include "atoms/commonsdivision.thrift"
include "atoms/chart.thrift"
Expand All @@ -29,8 +28,8 @@ enum AtomType {
CTA = 4,
INTERACTIVE = 5,
REVIEW = 6,
RECIPE = 7,
// STORYQUESTIONS = 8, DEPRECATED
//RECIPE = 7, DEPRECATED in favour of Recipe Element
//STORYQUESTIONS = 8, DEPRECATED
QANDA = 9,
PROFILE = 10,
GUIDE = 11,
Expand All @@ -49,8 +48,8 @@ union AtomData {
5: cta.CTAAtom cta
6: interactive.InteractiveAtom interactive
7: review.ReviewAtom review
8: recipe.RecipeAtom recipe
// 9: storyquestions.StoryQuestionsAtom storyquestions DEPRECATED
//8: recipe.RecipeAtom recipe DEPRECATED
//9: storyquestions.StoryQuestionsAtom storyquestions DEPRECATED
10: qanda.QAndAAtom qanda
11: guide.GuideAtom guide
12: profile.ProfileAtom profile
Expand Down

0 comments on commit c334e99

Please sign in to comment.