Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI element to toggle language #24

Merged
merged 17 commits into from
Jan 19, 2025
Merged

Add UI element to toggle language #24

merged 17 commits into from
Jan 19, 2025

Conversation

hanrodz
Copy link
Member

@hanrodz hanrodz commented Jan 19, 2025

Description

Add language toggle to navigation bar (the component works both for desktop and mobile, shouldn't make work towards #15 any more complicated).
Closes #13.

Milestones

Makes website available in English which will be great to attract more students and share with potential sponsors and partners.

Resources

You Can Definitely Use Global Variables To Manage Global State In React

Test Plan

Desktop Mobile
Screenshot 2025-01-19 at 02 45 49 Screenshot 2025-01-19 at 02 46 00

@hanrodz hanrodz added the enhancement New feature or request label Jan 19, 2025
@hanrodz hanrodz self-assigned this Jan 19, 2025
frontend/src/sections/LandingPage.tsx Outdated Show resolved Hide resolved
frontend/src/app/locale.tsx Show resolved Hide resolved
Copy link
Member

@CristobalMe CristobalMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanrodz hanrodz merged commit ac132d9 into main Jan 19, 2025
@hanrodz hanrodz deleted the 13-lang-toggle branch January 19, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide UI element to toggle language
2 participants