Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/overwrite collector registration #2288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix/overwrite collector registration #2288

wants to merge 1 commit into from
+46 −20

Conversation

robert-cronin
Copy link
Contributor

@robert-cronin robert-cronin commented Nov 12, 2024 •
edited
Loading

Description of the PR

Fixes #1616

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@robert-cronin robert-cronin force-pushed the fix/overwrite-collector-registration branch from 9ede279 to 79b9253 Compare November 12, 2024 06:41
lumjjb
lumjjb approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robert-cronin robert-cronin force-pushed the fix/overwrite-collector-registration branch from 79b9253 to 07a85d4 Compare November 13, 2024 03:07
@lumjjb
Copy link
Contributor

lumjjb commented Nov 13, 2024

@robert-cronin can you rebase, which should fix the ci errors. thanks!

@robert-cronin robert-cronin force-pushed the fix/overwrite-collector-registration branch 3 times, most recently from b2641b9 to f1cb993 Compare November 17, 2024 22:43
@robert-cronin robert-cronin force-pushed the fix/overwrite-collector-registration branch from f1cb993 to a9e7f6f Compare November 18, 2024 03:00
@robert-cronin
Copy link
Contributor Author

Added some changes to the test suite in order to allow registering the same collector again for each case. cc @pxp928 @lumjjb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do Not Overwrite collectors
3 participants
@robert-cronin @lumjjb @pxp928