-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search for Vulns via Artifact #2153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pxp928 <[email protected]>
Signed-off-by: pxp928 <[email protected]>
Signed-off-by: pxp928 <[email protected]>
nathannaveen
force-pushed
the
searchVulnsViaArtifact
branch
from
September 27, 2024 19:02
3ff353d
to
48becea
Compare
nathannaveen
added a commit
to nathannaveen/guac-docs
that referenced
this pull request
Sep 30, 2024
* This PR was created because of guacsec/guac#2153 Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
nathannaveen
force-pushed
the
searchVulnsViaArtifact
branch
from
September 30, 2024 16:43
48becea
to
f292dbc
Compare
pxp928
reviewed
Sep 30, 2024
nathannaveen
added a commit
to nathannaveen/guac-docs
that referenced
this pull request
Sep 30, 2024
* This PR was created because of guacsec/guac#2153 Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
nathannaveen
force-pushed
the
searchVulnsViaArtifact
branch
from
September 30, 2024 20:11
c14e45e
to
52c423f
Compare
pxp928
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
mihaimaruseac
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
With the hasSBOM nodes being attached to artifacts as well as packages, we have to also search hasSBOM nodes via artifacts as well as packages to find vuln nodes.
This PR includes the functionality to search for vuln nodes via artifacts in addition to our already implemented functionality to search via packages.
Feature change:
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run