-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a Delete functionality for KeyValue #2033
base: main
Are you sure you want to change the base?
Implemented a Delete functionality for KeyValue #2033
Conversation
586fda0
to
f0176af
Compare
5beeb63
to
c8b6ae5
Compare
} | ||
|
||
// Update the entity in the KeyValue store | ||
return c.kv.Set(ctx, col, id, newLinks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't correct. It is replacing the vuln and package structs/nodes with a string array. You need to get / modify / and set those structs. Should probably use the setkv()
helper (https://github.com/guacsec/guac/blob/main/pkg/assembler/backends/keyvalue/backend.go#L248)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this review! This review made me think deeply, and I realized that I was setting the key value wrong, so I have fixed that, as well as modifying the structs and not replacing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not right and doing the same thing.
c5f0927
to
2980fe7
Compare
After some thought, I realize that the code is going to require a lot of changes. So I am going to be converting this to a draft PR. This is mainly because of a deep dive into the comment #2033 (comment) by @jeffmendoza. |
8708cb0
to
6c01d0c
Compare
@nathannaveen this needs a rebase |
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
6c01d0c
to
e8c024f
Compare
Description of the PR
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run