Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for hasSBOMs via Artifacts in Vuln cli #1965

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

  • This adds a search for hasSBOM nodes via Artifact nodes in the vulnerability cli.
  • Fixes Attach HasSboms to Artifacts instead of Packages when possible #1736.
    • Note that this only addresses the first part: "update the Vuln CLI to take in hash to search for hasSBOM”.
    • The second part: “Update the patch planning CLI to use hasSBOM dependencies and not direct isDependency when calculating patch plan”. Can’t be done because patch planning is meant to find dependents, and hasSBOM nodes don’t search via dependents, only via dependencies.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen force-pushed the nathan/hasSBOMSearch branch 2 times, most recently from 911c72d to 273fcc8 Compare June 12, 2024 20:21
@pxp928 pxp928 added the needs-review Needs writer LGTM label Jun 25, 2024
@lumjjb lumjjb self-requested a review July 1, 2024 15:46
cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
@nathannaveen nathannaveen force-pushed the nathan/hasSBOMSearch branch 2 times, most recently from 3fe1418 to eb28f82 Compare July 18, 2024 21:47
@nathannaveen nathannaveen requested a review from lumjjb July 19, 2024 16:07
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits

pkg/guacanalytics/searchForSBOM.go Outdated Show resolved Hide resolved
pkg/guacanalytics/searchForSBOM.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit c7501e8 into guacsec:main Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Needs writer LGTM size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach HasSboms to Artifacts instead of Packages when possible
3 participants