-
-
Notifications
You must be signed in to change notification settings - Fork 25
Apply "Parse fields in classes and generate correct class structs" in gir #35
Conversation
Seems rust still have regression 😭 |
#[repr(C)] | ||
pub struct GdkWindow(c_void); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange empty line in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems difference between last class and first interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't really mind, just wanted to have more context. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @eugene2k
Wo, awesome! I'll just wait for appveyor and ignore beta/release for travis. This is really annoying. :-/ |
appveyor failed with a "normal" error. |
@GuillaumeGomez so you don't against this change? |
Removed empty lines between classes and interfaces by removing first line in |
I don't however, however, you must fix appveyor's failure first. |
Fixed appveyor upgrading rust to 1.9 (stable will fail), so we need decide what we need ask @eugene2k to do. |
Updated with results of gtk-rs/gir#298 |
7ae8ac4
to
71498c3
Compare
Updated, ready for merge |
Thanks! |
Example result of gtk-rs/gir#276
WIP
cc @GuillaumeGomez
Closes #34