Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Apply "Parse fields in classes and generate correct class structs" in gir #35

Merged
merged 3 commits into from
Dec 8, 2016

Conversation

EPashkin
Copy link
Member

@EPashkin EPashkin commented Dec 7, 2016

Example result of gtk-rs/gir#276
WIP
cc @GuillaumeGomez
Closes #34

@EPashkin EPashkin changed the title Test regen Apply "Parse fields in classes and generate correct class structs" in gir Dec 7, 2016
@EPashkin
Copy link
Member Author

EPashkin commented Dec 7, 2016

Related issue #34, #25.

@EPashkin
Copy link
Member Author

EPashkin commented Dec 7, 2016

Seems rust still have regression 😭

#[repr(C)]
pub struct GdkWindow(c_void);


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange empty line in here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems difference between last class and first interface

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't really mind, just wanted to have more context. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillaumeGomez
Copy link
Member

Wo, awesome! I'll just wait for appveyor and ignore beta/release for travis. This is really annoying. :-/

@GuillaumeGomez
Copy link
Member

appveyor failed with a "normal" error.

@EPashkin
Copy link
Member Author

EPashkin commented Dec 7, 2016

@GuillaumeGomez so you don't against this change?

@EPashkin
Copy link
Member Author

EPashkin commented Dec 7, 2016

Removed empty lines between classes and interfaces by removing first line in generate_interfaces_structs

@GuillaumeGomez
Copy link
Member

I don't however, however, you must fix appveyor's failure first.

@EPashkin
Copy link
Member Author

EPashkin commented Dec 7, 2016

Fixed appveyor upgrading rust to 1.9 (stable will fail), so we need decide what we need ask @eugene2k to do.

@EPashkin
Copy link
Member Author

EPashkin commented Dec 8, 2016

Updated with results of gtk-rs/gir#298

@EPashkin EPashkin force-pushed the generate_class_structs branch from 7ae8ac4 to 71498c3 Compare December 8, 2016 18:25
@EPashkin
Copy link
Member Author

EPashkin commented Dec 8, 2016

Updated, ready for merge

@GuillaumeGomez
Copy link
Member

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 11c911e into gtk-rs:master Dec 8, 2016
@EPashkin EPashkin deleted the generate_class_structs branch December 8, 2016 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants