Add gdk4-win32

[elmarco]

I could use some help, it currently fails with:

$ ../gir/target/release/gir -o . -m not_bound                                                                                                                        
[WARN  libgir::analysis::functions] `Win32MessageFilterFunc`: unknown type
[WARN  libgir::analysis::functions] `add_filter`: this is supposed to be a callback function but no callback was found...
[WARN  libgir::analysis::functions] `Win32MessageFilterFunc`: unknown type
[WARN  libgir::analysis::functions] `remove_filter`: this is supposed to be a callback function but no callback was found...
[NOT GENERATED METHOD] GdkWin32.Win32Display::add_filter because of GdkWin32.Win32MessageFilterFunc
[NOT GENERATED METHOD] GdkWin32.Win32Display::remove_filter because of GdkWin32.Win32MessageFilterFunc

and

error[E0433]: failed to resolve: use of undeclared crate or module `win32`
  --> gdk4-win32/src/auto/win32_hcursor.rs:25:48
   |
25 |     pub fn new(display: &Win32Display, handle: win32::HCURSOR, destroyable: bool) -> Win32HCursor {
   |                                                ^^^^^ use of undeclared crate or module `win32`

error[E0433]: failed to resolve: use of undeclared crate or module `win32`
  --> gdk4-win32/src/auto/win32_surface.rs:21:55
   |
21 |     pub fn handle(window: &impl IsA<gdk::Surface>) -> win32::HGDIOBJ {
   |                                                       ^^^^^ use of undeclared crate or module `win32`

error[E0433]: failed to resolve: use of undeclared crate or module `win32`
  --> gdk4-win32/src/auto/win32_surface.rs:28:58
   |
28 |     pub fn impl_hwnd(window: &impl IsA<gdk::Surface>) -> win32::HWND {
   |                                                          ^^^^^ use of undeclared crate or module `win32`

error[E0433]: failed to resolve: use of undeclared crate or module `win32`
  --> gdk4-win32/src/auto/win32_surface.rs:44:71
   |
44 |     pub fn lookup_for_display(display: &impl IsA<gdk::Display>, anid: win32::HWND) -> gdk::Surface {
   |                                                                       ^^^^^ use of undeclared crate or module `win32`

[elmarco]

I test the build with the pending Fedora package:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2119295

export PKG_CONFIG_SYSROOT_DIR=/usr/x86_64-w64-mingw32/sys-root/mingw/
export PKG_CONFIG_PATH=/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig

cargo build --target x86_64-pc-windows-gnu

[bilelmoussaoui]

I would also look at updating the windows job to build gdk-win so we are sure it works. I will look into reserving the name on crates.io ;)

[bilelmoussaoui]

Would you mind changing the windows CI to re-build everytime the gdk-win32 is changed, see https://github.com/gtk-rs/gtk4-rs/blob/master/.github/workflows/windows-msvc.yml#L6-L18, as well as adding a step here https://github.com/gtk-rs/gtk4-rs/blob/master/.github/workflows/windows-msvc.yml#L91-L95 for build, test & clippy gdk-win32

[bilelmoussaoui]

Would you mind changing the windows CI to re-build everytime the gdk-win32 is changed, see https://github.com/gtk-rs/gtk4-rs/blob/master/.github/workflows/windows-msvc.yml#L6-L18, as well as adding a step here https://github.com/gtk-rs/gtk4-rs/blob/master/.github/workflows/windows-msvc.yml#L91-L95 for build, test & clippy gdk-win32

I forgot that we should do the same for the docs job, especially the part in https://github.com/gtk-rs/gtk4-rs/blob/master/.github/workflows/docs.yml#L70 otherwise we won't get any gdk-win32 docs.

[bilelmoussaoui]

One last CI change is needed: https://github.com/gtk-rs/gtk4-rs/blob/master/.github/workflows/CI.yml#L5-L23 & https://github.com/gtk-rs/gtk4-rs/blob/master/.github/workflows/CI.yml#L145-L151 and it is ready to go

[bilelmoussaoui]

Sorry for always bringing yet another change to do, but the main readme at https://github.com/gtk-rs/gtk4-rs#gtk4-rs- mentions the various supported gdk backends, would it be possible to add a line for gdk win32? thanks